π bug fix: adopt agy onboarding wizard relay support - #5753
Conversation
`agy` is a first-class backend throughout this file (launch flags, --effort
handling, capability reporting) but getCLIState() has no branch for it, so an
Antigravity pane always fell through to 'unknown'. The relay then waited out
CLI_READY_TIMEOUT_MS and handed the task back β with the CLI sitting on a
dismissible dialog the whole time.
Antigravity gates first run behind a three-step wizard: colour scheme -> Terms
of Service -> folder trust. This is not a once-per-image cost: agents that
share a $HOME symlink one ~/.gemini, and whenever one writes
antigravity-cli/cache/onboarding.json mode 600 every OTHER agent gets EACCES
and re-enters the wizard from the start.
Two changes:
- getCLIState() gains an `agy` branch mapping the wizard to 'onboarding', the
"not signed in / Select login method" screen to 'needs-login', and the
banner/prompt to 'ready'.
- blockingPromptKey() learns the Terms of Service step. It is the one page a
bare Enter cannot leave: focus sits on the consent CHECKBOX, where Enter
toggles rather than advances ("enter Toggle"), so the relay would dismiss in
a loop until timeout. Down moves to the button row and Right selects [Done];
the caller appends Enter. The colour-scheme and folder-trust steps DO advance
on a bare Enter and deliberately return null.
Verified against real captured panes from a live fleet: all five agy states
classify correctly, and codex's existing prompts are unaffected.
Signed-off-by: James Reilly <jreilly1821@gmail.com>
Adopt hanthor's Antigravity onboarding support and fold it into the existing agy readiness branch with tail-scoped gates and regression coverage.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
/lgtm |
|
/approve |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Adopts hanthor's #5661 from the fork so the queue can drain after maintainer pushes to the fork were rejected.\n\nThis preserves hanthor's authored commit and adds the validated fix requested on the original PR: the agy onboarding/login checks are folded into the existing agy branch, readiness remains the tight '? for shortcuts' gate, onboarding detection is tail-scoped, ToS dismissal is agy-specific and button-row-specific, and regression tests cover the false positives.\n\nValidation:\n- node bin/contributor-relay.test.js (293/293 passed)\n- cd src && go build ./...\n\nCredits: original implementation by @hanthor in #5661.